write/macho: ensure padding matches for section file offset and address #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I can confirm that this fixes the issue. Would you mind backporting this to object 0.30? Otherwise I will be stuck with broken CI for cg_clif for the next couple of weeks until a new Cranelift release depending on object 0.31 gets released. |
philipc
added a commit
to philipc/object
that referenced
this pull request
Jun 5, 2023
philipc
added a commit
that referenced
this pull request
Jun 6, 2023
poliorcetics
pushed a commit
to JustRustThings/object
that referenced
this pull request
Jul 24, 2023
sampsyo
added a commit
to sampsyo/bril
that referenced
this pull request
Oct 7, 2023
Brilift AOT didn't previously support macOS-on-ARM because `cranelift-object` didn't, which in turn is because the `object` crate was missing some relevant features. It seems like that support has been added, possibly in this PR but I'm not sure: gimli-rs/object#553 Anyway, stuff seems to be working on ARM now, which is cool. Now we can remove the hacks to insist on Rosetta2 when on Apple Silicon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552
cc @bjorn3