add support for csky arch(elf) #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All matches seem to be sorted by variant name. Could you insert the Csky variant at the right place to keep it sorted? |
bjorn3
reviewed
Jul 14, 2023
src/common.rs
Outdated
| @@ -29,6 +29,7 @@ pub enum Architecture { | |||
| Wasm32, | |||
| Wasm64, | |||
| Xtensa, | |||
| CSKY, | |||
There was a problem hiding this comment.
Suggested change
| CSKY, | |
| Csky, |
Rustc warns about non-CamelCase names.
philipc
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Thanks for the PR. Please also add support in these two places:
Line 154 in b237c5c
object/tests/round_trip/mod.rs
Line 231 in b237c5c
philipc
approved these changes
Jul 18, 2023
poliorcetics
pushed a commit
to JustRustThings/object
that referenced
this pull request
Jul 24, 2023
|
When will the next version be released |
|
I don't think there's been any breaking changes yet, so I can do a point release when needed. |
|
0.32.0 has been published. |
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.