Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream gimli #17

Merged
merged 3 commits into from
Aug 1, 2018
Merged

Use upstream gimli #17

merged 3 commits into from
Aug 1, 2018

Conversation

roblabla
Copy link
Contributor

@roblabla roblabla commented Aug 1, 2018

The PR that goes with gimli-rs/gimli#316.

It also fixes the examples which were broken by the env_logger bump.

main--
main-- approved these changes Aug 1, 2018
View reviewed changes
Copy link
Collaborator

@main-- main-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the gimli PR gets merged, we still need to wait for a new release so we're stuck with a git dependency for now.

@main-- main-- merged commit 1cede08 into gimli-rs:master Aug 1, 2018
@kitlith kitlith mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@main-- main-- main-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roblabla @main--