Initial proposal for a Gin wrapper that provide graceful shutdown. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2023
appleboy
requested changes
Jul 28, 2023
coverage.txt
Outdated
| @@ -0,0 +1,65 @@ | |||
| mode: atomic | |||
There was a problem hiding this comment.
Oops, good catch.
.gitignore
Outdated
| @@ -22,3 +22,6 @@ _testmain.go | |||
| *.exe | |||
| *.test | |||
| *.prof | |||
|
|
|||
| coverage.out | |||
.github/workflows/go.yml
Outdated
| - name: Setup golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| version: v1.49.0 |
.github/workflows/go.yml
Outdated
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| go: [1.17, 1.18, 1.19, '1.20'] |
|
I think I have addressed all the first batch of comments. Is there anything I can do to help? |
appleboy
approved these changes
Aug 18, 2023
|
@cedric-appdirect Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content of .github come from
gin-contrib/loggerand the test are inspired by gin test.