refactor: use gin.IRouter instead of gin.Engine #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change parameter type of `Register` function to `gin.IRouter` - Fix typo in comment in `pprof.go` - Omitted large changes in files diff summary
appleboy
approved these changes
May 5, 2024
|
@Laisky Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thinks it would be better for developer to use
gin.IRouterinterface thangin.Engine.gin.Engineis the root router for server. However, there are situations where only the sub-routes obtained after multiple calls to.Groupare passed in the code, that isgin.IRouter. In such cases, it becomes difficult to bind pprof.