Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash by 'interface {} is runtime.errorString, not string' #10

Merged
merged 1 commit into from
Sep 11, 2019
Merged

fix crash by 'interface {} is runtime.errorString, not string' #10

merged 1 commit into from
Sep 11, 2019

Conversation

csbzy
Copy link
Contributor

@csbzy csbzy commented May 8, 2019

fix #9

@lucat1
Copy link

lucat1 commented Jun 9, 2019

Any updates on this? Really need this fix

@Terminator637
Copy link

Please merge this.

JohnStarich added a commit to JohnStarich/sage that referenced this pull request Jun 20, 2019
@JohnStarich
Add custom recovery until this is merged: gin-contrib/zap#10
3de3c39
@csbzy
Copy link
Contributor Author

csbzy commented Jun 21, 2019

@appleboy please check this

@appleboy appleboy merged commit a584a3a into gin-contrib:master Sep 11, 2019
@appleboy
Copy link
Member

@csbzy Sorry for late to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

will crash if err is runtime.errorString
4 participants
@csbzy @lucat1 @Terminator637 @appleboy