Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context): add BindQuery func #1029

Merged
merged 7 commits into from
Jul 19, 2017

Conversation

easonlin404
Copy link
Contributor

see #742 (comment) , only parse/bind the query string params

@codecov
Copy link

codecov bot commented Jul 17, 2017

Codecov Report

Merging #1029 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   96.61%   96.61%   +<.01%     
==========================================
  Files          16       16              
  Lines        1712     1714       +2     
==========================================
+ Hits         1654     1656       +2     
  Misses         50       50              
  Partials        8        8
Impacted Files Coverage Δ
context.go 96.61% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74221b8...29998e1. Read the comment docs.

@appleboy appleboy added this to the 1.3 milestone Jul 18, 2017
@appleboy
Copy link
Member

@easonlin404 Please also add a new section on readme.

@easonlin404
Copy link
Contributor Author

@appleboy Already update readme. Thanks.

README.md Outdated
package main

import "log"
import "github.com/gin-gonic/gin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import (
	"log"

	"github.com/gin-gonic/gin"
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. thanks for your kind reminder.

@javierprovecho javierprovecho merged commit c19aa05 into gin-gonic:master Jul 19, 2017
@easonlin404 easonlin404 deleted the BindQuery branch July 19, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants