Expose HandlerFunc in RouteInfos #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1272 +/- ##
==========================================
+ Coverage 99.27% 99.27% +<.01%
==========================================
Files 39 39
Lines 1929 1931 +2
==========================================
+ Hits 1915 1917 +2
Misses 10 10
Partials 4 4
Continue to review full report at Codecov.
|
appleboy
approved these changes
Mar 20, 2018
|
Can we merge this ? @appleboy |
paulolimarb
approved these changes
Sep 16, 2018
|
Waiting for @thinkerou review. |
|
@loopfz Thank you for your work, if you can update them annotation it's very nice, LGTM. |
thinkerou
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to have access to the HandlerFunc in RouteInfos, to write utilities around gin.
This resolves #506 for me.