Add Pusher() function for support http2 server push #1273
Conversation
|
@htobenothing you should add some unit test case, and http.Pusher is supported only go1.8+, thanks! |
|
Hi @htobenothing, I was going to make a pull request last night on the same subject. // ResponseWriter is used by an Gin HTTP handler to
// construct an HTTP response.
type ResponseWriter interface {
// ...
// Pusher returns the http.Pusher for server push if it supported.
Pusher() (http.Pusher, bool)
// ...
}
// Pusher returns the http.Pusher interface if supported by the response.
func (w *responseWriter) Pusher() (pusher http.Pusher, ok bool) {
pusher, ok = w.ResponseWriter.(http.Pusher)
return
}@thinkerou How to do with the current official support of Go 1.6 and 1.7, without rewriting too much code ? A new minor version ? |
|
any progress on this feature? |
|
go1.6 and go1.7 will have the following error: response_writer.go:42: undefined: http.Pusher |
|
Build tags could be used to conditionally compile the Pusher() method only on go >= 1.8 |
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
- Coverage 98.21% 97.99% -0.22%
==========================================
Files 35 36 +1
Lines 1844 1848 +4
==========================================
Hits 1811 1811
- Misses 26 30 +4
Partials 7 7
Continue to review full report at Codecov.
|
|
@thinkerou @htobenothing @jsnathan @rvflash @dreambo8563 I updated the code base that supports go1.7 and go1.8 onward version now. Please help to review and give me some feedbacks. |
|
Hi @appleboy in my option, type ResponseWriter interface {
responseWriterBase
}and in type ResponseWriter interface {
responseWriterBase
// get the http.Pusher for server push
Pusher() http.Pusher
}
func (w *responseWriter) Pusher() (pusher http.Pusher) {
if pusher, ok := w.ResponseWriter.(http.ResponseWriter).(http.Pusher); ok {
return pusher
}
return nil
}prime target reduce duplicate code. |
|
Add http2 push exmaple. package main
import (
"html/template"
"log"
"github.com/gin-gonic/gin"
)
var html = template.Must(template.New("https").Parse(`
<html>
<head>
<title>Https Test</title>
<script src="/assets/app.js"></script>
</head>
<body>
<h1 style="color:red;">Welcome, Ginner!</h1>
</body>
</html>
`))
func main() {
r := gin.Default()
r.Static("/assets", "./assets")
r.SetHTMLTemplate(html)
r.GET("/", func(c *gin.Context) {
if pusher := c.Writer.Pusher(); pusher != nil {
// use pusher.Push() to do server push
if err := pusher.Push("/assets/app.js", nil); err != nil {
log.Printf("Failed to push: %v", err)
}
}
c.HTML(200, "https", gin.H{
"status": "success",
})
})
// Listen and Server in https://127.0.0.1:8080
r.RunTLS(":8080", "./testdata/server.pem", "./testdata/server.key")
} |
|
@thinkerou thanks for your feedback. Done. see fa81624 |
|
LGTM, but should add some test case for |
|
Thank you for adding this feature! |
|
Sorry for the late, I was in vacation. Thanks @appleboy @thinkerou @jsnathan for adding this feature! |
|
We're having a regression in our code (go 1.8) due to a an updated gin version and I suspect this change is causing it The following code return func(c *gin.Context) {
var wb *customWritter
if w, ok := c.Writer.(gin.ResponseWriter); ok {
wb = &customWritter{context: c, response: w, body: &bytes.Buffer{}}
c.Writer = wbyields this compilation error: Is there a workaround for this? otherwise we should stick strictly to v1.2.0 |
|
@lggomez you should use the master branch. |
gin already support http2, while previously not support server push.
Add Pusher() function to extend the ResponseWriter interface.