flush operation will overwrite the origin status code #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1460 +/- ##
==========================================
+ Coverage 98.68% 98.68% +<.01%
==========================================
Files 36 36
Lines 1894 1895 +1
==========================================
+ Hits 1869 1870 +1
Misses 18 18
Partials 7 7
Continue to review full report at Codecov.
|
appleboy
previously approved these changes
Aug 6, 2018
|
any feedback @thinkerou ? |
javierprovecho
previously approved these changes
Aug 6, 2018
thinkerou
reviewed
Aug 7, 2018
response_writer_test.go
Outdated
| writer := &responseWriter{} | ||
| writer.reset(w) | ||
|
|
||
| writer.WriteHeader(500) |
There was a problem hiding this comment.
I like http.StatusInternalServerError
thinkerou
reviewed
Aug 7, 2018
response_writer_test.go
Outdated
| // should return 500 | ||
| resp, err := http.Get(testServer.URL) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, resp.StatusCode, 500) |
There was a problem hiding this comment.
use http.StatusInternalServerError? and you should use assert.Equal(t, expect, actual)
|
please see my comment, a small problem, and then LGTM. |
congcongke
dismissed stale reviews from javierprovecho and appleboy
via
4a6eea7
appleboy
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status of responseWriter will be overwrite if flush was called. This is caused by the Flush of http.response.Flush().