Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean the Request Path early #1817

Merged
merged 2 commits into from
May 7, 2019
Merged

Clean the Request Path early #1817

merged 2 commits into from
May 7, 2019

Conversation

dmarkham
Copy link
Contributor

This will reduce the number of times we have to do a redirect
and allow multiple slashes in path to be routed!
fixes #1644

@dmarkham
Clean the Request Path early
fdad5ae 
This will reduce the number of times we have todo a redirect.
and allow multiple slashes in path to be routed!
fixes gin-gonic#1644
@dmarkham
Copy link
Contributor Author

Looks like the 1.6.x tests are failing. Are we planning on keeping 1.6 supported?

If so I will need to rework performRequest a little bit. httptest.NewRequest is built for testing the server side requests and better supports the testing environment.
For example http.NewRequest given a url of //foo/bar will interpret foo is the host in a url not part of the path. httptest.NewRequest knows exactly what to do and is the documented way since version 1.7.x. Thoughts and Suggestions are very welcome.

@thinkerou
Copy link
Member

@dmarkham

Are we planning on keeping 1.6 supported?

Hi, we will remove go1.6/1.7 supported at gin1.4 or gin1.5.

@thinkerou
Copy link
Member

waiting for #1631

@thinkerou thinkerou added this to the 1.4 milestone May 7, 2019
@codecov
Copy link

codecov bot commented May 7, 2019 •
edited
Loading

Codecov Report

Merging #1817 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
+ Coverage   98.74%   98.74%   +<.01%     
==========================================
  Files          38       38              
  Lines        2143     2144       +1     
==========================================
+ Hits         2116     2117       +1     
  Misses         15       15              
  Partials       12       12
Impacted Files Coverage Δ
gin.go 99.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d2c30...52683b0. Read the comment docs.

@thinkerou thinkerou merged commit b642568 into gin-gonic:master May 7, 2019
This was referenced Nov 26, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@thinkerou thinkerou thinkerou approved these changes

@javierprovecho javierprovecho Awaiting requested review from javierprovecho

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Multiple slashes in path is not working
3 participants
@dmarkham @thinkerou @appleboy