Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix accept incoming network connections" #2294

Merged
merged 1 commit into from Mar 23, 2020

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Mar 23, 2020

Reverts #2216 and fix #2292

@appleboy appleboy added the bug label Mar 23, 2020
@appleboy appleboy added this to the 1.6.1 milestone Mar 23, 2020
@appleboy appleboy requested a review from thinkerou Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #2294 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2294   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files          41       41           
  Lines        2298     2298           
=======================================
  Hits         2263     2263           
  Misses         20       20           
  Partials       15       15           
Impacted Files Coverage Δ
utils.go 97.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae88831...e8e308d. Read the comment docs.

@appleboy
Copy link
Member Author

appleboy commented Mar 23, 2020

@keob already confrim this bug.

@keob
Copy link
Contributor

keob commented Mar 23, 2020

Yes

Copy link
Member

@thinkerou thinkerou left a comment

LGTM

@thinkerou thinkerou merged commit 1bebd9a into master Mar 23, 2020
4 checks passed
byebyebruce pushed a commit to byebyebruce/gin that referenced this pull request Mar 25, 2020
@thinkerou thinkerou deleted the revert-2216-fix-net-allow branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New behavior of r.Run binds to localhost, not 0.0.0.0, issues in Docker
3 participants