Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update:SetMode function #2321

Merged
merged 1 commit into from Apr 16, 2020
Merged

update:SetMode function #2321

merged 1 commit into from Apr 16, 2020

Conversation

@bestgopher
Copy link
Contributor

@bestgopher bestgopher commented Apr 16, 2020

I think this is more elegant。In switch-case,we don't need judge that value is ""

@codecov
Copy link

@codecov codecov bot commented Apr 16, 2020

Codecov Report

Merging #2321 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2321   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          41       41           
  Lines        2304     2304           
=======================================
  Hits         2267     2267           
  Misses         21       21           
  Partials       16       16           
Impacted Files Coverage Δ
mode.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f20888...1b5835f. Read the comment docs.

@thinkerou thinkerou requested review from thinkerou and appleboy Apr 16, 2020
@thinkerou thinkerou added this to the 1.7 milestone Apr 16, 2020
Copy link
Member

@thinkerou thinkerou left a comment

LGTM

@bestgopher bestgopher requested a review from thinkerou Apr 16, 2020
@appleboy appleboy merged commit a4e947a into gin-gonic:master Apr 16, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants