Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tree #2371

Merged
merged 9 commits into from Jan 3, 2021
Merged

chore: update tree #2371

merged 9 commits into from Jan 3, 2021

Conversation

@thinkerou
Copy link
Member

@thinkerou thinkerou commented May 12, 2020

if !cond {
}
// else code

instead of

if cond {
} else {
}
@codecov
Copy link

@codecov codecov bot commented May 12, 2020

Codecov Report

Merging #2371 (0eb2d6b) into master (3b5e861) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.01%     
==========================================
  Files          41       41              
  Lines        1974     1973       -1     
==========================================
- Hits         1944     1943       -1     
  Misses         17       17              
  Partials       13       13              
Impacted Files Coverage Δ
tree.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5e861...0eb2d6b. Read the comment docs.

@thinkerou thinkerou requested a review from appleboy May 12, 2020
@thinkerou thinkerou added this to the 1.7 milestone May 12, 2020
@thinkerou
Copy link
Member Author

@thinkerou thinkerou commented May 13, 2020

@appleboy I don't know why coverage diff failed.

@appleboy appleboy merged commit a573ec6 into gin-gonic:master Jan 3, 2021
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants