Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some functions that have the same effect as the bytes package #2387

Merged
merged 1 commit into from May 23, 2020
Merged

Remove some functions that have the same effect as the bytes package #2387

merged 1 commit into from May 23, 2020

Conversation

@bestgopher
Copy link
Contributor

@bestgopher bestgopher commented May 23, 2020

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

There are two same functions in github.com/gin-gonic/gin/internal/bytesconv.

@codecov
Copy link

@codecov codecov bot commented May 23, 2020

Codecov Report

Merging #2387 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
- Coverage   98.64%   98.63%   -0.01%     
==========================================
  Files          41       41              
  Lines        2359     2348      -11     
==========================================
- Hits         2327     2316      -11     
  Misses         18       18              
  Partials       14       14              
Impacted Files Coverage Δ
tree.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbb3d4...411f58e. Read the comment docs.

@thinkerou thinkerou requested a review from appleboy May 23, 2020
@thinkerou thinkerou added this to the 1.7 milestone May 23, 2020
@appleboy appleboy merged commit 7bffae1 into gin-gonic:master May 23, 2020
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants