Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove a unused type SecureJSONPrefix #2391

Merged
merged 2 commits into from May 24, 2020
Merged

remove a unused type SecureJSONPrefix #2391

merged 2 commits into from May 24, 2020

Conversation

@bestgopher
Copy link
Contributor

@bestgopher bestgopher commented May 23, 2020

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

remove an unused type SecureJSONPrefix in render/json.go

@codecov
Copy link

@codecov codecov bot commented May 23, 2020

Codecov Report

Merging #2391 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2391   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          41       41           
  Lines        2348     2348           
=======================================
  Hits         2316     2316           
  Misses         18       18           
  Partials       14       14           
Impacted Files Coverage Δ
render/json.go 87.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2773ce6...d3bd49c. Read the comment docs.

.gitignore Outdated
@@ -5,3 +5,4 @@ count.out
test
profile.out
tmp.out
.idea/
Copy link
Member

@appleboy appleboy May 24, 2020

Please revert this.

Copy link
Contributor Author

@bestgopher bestgopher May 24, 2020

Done.

@appleboy appleboy added this to the 1.7 milestone May 24, 2020
@appleboy appleboy merged commit 9221381 into gin-gonic:master May 24, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants