Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetUint and GetUint64 method on gin.context #2487

Merged
merged 1 commit into from Sep 1, 2020
Merged

Conversation

@kaiiak
Copy link
Contributor

@kaiiak kaiiak commented Aug 31, 2020

close #2432

@kaiiak
Copy link
Contributor Author

@kaiiak kaiiak commented Aug 31, 2020

@thinkerou @appleboy I recommit a pr, please review it, thanks.

@codecov
Copy link

@codecov codecov bot commented Aug 31, 2020

Codecov Report

Merging #2487 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2487   +/-   ##
=======================================
  Coverage   98.72%   98.73%           
=======================================
  Files          41       41           
  Lines        2359     2367    +8     
=======================================
+ Hits         2329     2337    +8     
  Misses         17       17           
  Partials       13       13           
Impacted Files Coverage Δ
context.go 98.12% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94d23d...1537b1c. Read the comment docs.

@thinkerou thinkerou requested review from thinkerou and appleboy Sep 1, 2020
@thinkerou thinkerou added this to the 1.7 milestone Sep 1, 2020
Copy link
Member

@thinkerou thinkerou left a comment

LGTM, thanks!

@thinkerou thinkerou merged commit 0304ee9 into gin-gonic:master Sep 1, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants