Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce allocs and improve the render WriteString #2508

Merged
merged 4 commits into from Oct 16, 2020

Conversation

@imxyb
Copy link
Contributor

@imxyb imxyb commented Sep 21, 2020

bencmp result

benchmark                     old ns/op     new ns/op     delta
BenchmarkReader_Render-12     581           545           -6.20%

benchmark                     old allocs     new allocs     delta
BenchmarkReader_Render-12     9              8              -11.11%

benchmark                     old bytes     new bytes     delta
BenchmarkReader_Render-12     1008          992           -1.59%
@codecov
Copy link

@codecov codecov bot commented Sep 21, 2020

Codecov Report

Merging #2508 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2508   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          41       41           
  Lines        1951     1951           
=======================================
  Hits         1921     1921           
  Misses         17       17           
  Partials       13       13           
Impacted Files Coverage Δ
render/text.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d541085...2fc291c. Read the comment docs.

@imxyb
Copy link
Contributor Author

@imxyb imxyb commented Oct 15, 2020

@appleboy PTAL, thanks

@appleboy appleboy requested review from appleboy and thinkerou Oct 15, 2020
@appleboy appleboy added this to the 1.7 milestone Oct 15, 2020
Copy link
Member

@thinkerou thinkerou left a comment

LGTM

@thinkerou thinkerou merged commit c83a1cc into gin-gonic:master Oct 16, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants