Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print headers without Authorization header on broken pipe #2528

Merged
merged 2 commits into from Oct 15, 2020

Conversation

@zachnewburgh
Copy link
Contributor

@zachnewburgh zachnewburgh commented Oct 13, 2020

Closes #2201

@codecov
Copy link

@codecov codecov bot commented Oct 13, 2020

Codecov Report

Merging #2528 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2528   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          41       41           
  Lines        1950     1951    +1     
=======================================
+ Hits         1920     1921    +1     
  Misses         17       17           
  Partials       13       13           
Impacted Files Coverage Δ
recovery.go 97.18% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1297966...e0196ea. Read the comment docs.

@zachnewburgh zachnewburgh changed the title fix: print headers without Authorization on broken pipe fix: print headers without Authorization header on broken pipe Oct 13, 2020
@appleboy appleboy added this to the 1.7 milestone Oct 14, 2020
Copy link
Member

@thinkerou thinkerou left a comment

LGTM

@thinkerou
Copy link
Member

@thinkerou thinkerou commented Oct 14, 2020

@appleboy I also have not permission.

@appleboy
Copy link
Member

@appleboy appleboy commented Oct 15, 2020

@thinkerou maybe something wrong with Travis? or we can move Traivs to GitHub Actions?

@thinkerou
Copy link
Member

@thinkerou thinkerou commented Oct 15, 2020

@thinkerou maybe something wrong with Travis? or we can move Traivs to GitHub Actions?

support!

@appleboy appleboy merged commit a7a6986 into gin-gonic:master Oct 15, 2020
3 checks passed
@zachnewburgh zachnewburgh deleted the patch-1 branch Oct 16, 2020
@ghoshabhi
Copy link

@ghoshabhi ghoshabhi commented Nov 13, 2020

@appleboy Do we know when will this change be released ? This would be a critical improvement.

cc @zachnewburgh

@appleboy
Copy link
Member

@appleboy appleboy commented Nov 13, 2020

@ghoshabhi We need to review the 1.7 milestone asap. https://github.com/gin-gonic/gin/milestone/12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants