Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouterGroup.Handle regular match optimization of http method #2685

Merged
merged 3 commits into from Apr 21, 2021
Merged

RouterGroup.Handle regular match optimization of http method #2685

merged 3 commits into from Apr 21, 2021

Conversation

daheige
Copy link
Contributor

@daheige daheige commented Apr 11, 2021

RouterGroup.Handle matches the optimization of http method. There is no need to do regular matching of reg every time. If there are multiple grouping routes, it will consume more performance.

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #2685 (a0a6813) into master (7313b8f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2685   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          41       41           
  Lines        2036     2036           
=======================================
  Hits         2009     2009           
  Misses         15       15           
  Partials       12       12           
Impacted Files Coverage Δ
routergroup.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7313b8f...a0a6813. Read the comment docs.

Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@thinkerou thinkerou requested review from thinkerou and appleboy Apr 15, 2021
@thinkerou thinkerou added this to the v1.8 milestone Apr 15, 2021
@thinkerou thinkerou merged commit f1da692 into gin-gonic:master Apr 21, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants