Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Header() instead of deprecated HeaderMap #2694

Merged

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Apr 17, 2021

HeaderMap is deprecated and should avoid to use.
Ref: https://golang.org/pkg/net/http/httptest/#ResponseRecorder

@thinkerou thinkerou requested review from thinkerou and appleboy Apr 17, 2021
@thinkerou thinkerou added this to the v1.8 milestone Apr 17, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2694 (537c9ae) into master (77649bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2694   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          41       41           
  Lines        2036     2036           
=======================================
  Hits         2009     2009           
  Misses         15       15           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77649bc...537c9ae. Read the comment docs.

@appleboy appleboy merged commit 7313b8f into gin-gonic:master Apr 20, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants