Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binding): support custom struct tag #2720

Merged
merged 3 commits into from Jun 29, 2021
Merged

Conversation

mtt0
Copy link
Contributor

@mtt0 mtt0 commented May 14, 2021

Add function `binding.MapFormWithTag` (gin-gonic#2719)
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #2720 (6e61cf8) into master (4fe5f3e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2720      +/-   ##
==========================================
+ Coverage   98.67%   98.70%   +0.02%     
==========================================
  Files          41       41              
  Lines        2036     2078      +42     
==========================================
+ Hits         2009     2051      +42     
  Misses         15       15              
  Partials       12       12              
Impacted Files Coverage Δ
binding/form_mapping.go 100.00% <100.00%> (ø)
recovery.go 97.14% <0.00%> (-0.05%) ⬇️
tree.go 100.00% <0.00%> (ø)
debug.go 100.00% <0.00%> (ø)
render/json.go 85.29% <0.00%> (ø)
binding/form.go 100.00% <0.00%> (ø)
render/msgpack.go 100.00% <0.00%> (ø)
binding/multipart_form_mapping.go 100.00% <0.00%> (ø)
gin.go 99.18% <0.00%> (+0.05%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe5f3e...6e61cf8. Read the comment docs.

daheige
daheige previously approved these changes Jun 5, 2021
README.md Show resolved Hide resolved
@appleboy appleboy added this to the v1.8 milestone Jun 25, 2021
mtt0 added 2 commits Jun 25, 2021
Add 'Bind form-data request with custom struct and custom tag' section (gin-gonic#2719)
@appleboy appleboy requested a review from thinkerou Jun 29, 2021
Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@thinkerou thinkerou merged commit 690aa2b into gin-gonic:master Jun 29, 2021
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants