Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback Context.Deadline() Context.Done() Context.Err() to Context.Request.Context() #2769

Merged
merged 2 commits into from Jul 31, 2021

Conversation

wei840222
Copy link
Contributor

@wei840222 wei840222 commented Jun 28, 2021

base on comment #2751 (comment) in #2751
also fallback Context.Deadline() Context.Done() Context.Err() to Context.Request.Context()

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #2769 (9cbbe83) into master (1d0f938) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2769      +/-   ##
==========================================
+ Coverage   98.70%   98.71%   +0.01%     
==========================================
  Files          41       41              
  Lines        2077     2100      +23     
==========================================
+ Hits         2050     2073      +23     
  Misses         15       15              
  Partials       12       12              
Impacted Files Coverage Δ
context.go 97.72% <100.00%> (+0.03%) ⬆️
tree.go 100.00% <0.00%> (ø)
routergroup.go 100.00% <0.00%> (ø)
binding/form_mapping.go 100.00% <0.00%> (ø)
binding/default_validator.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0f938...9cbbe83. Read the comment docs.

@appleboy appleboy added this to the v1.8 milestone Jun 28, 2021
appleboy
appleboy previously approved these changes Jul 5, 2021
@appleboy appleboy requested a review from thinkerou Jul 5, 2021
thinkerou
thinkerou previously approved these changes Jul 5, 2021
Copy link
Member

@thinkerou thinkerou left a comment

lgtm

context.go Outdated Show resolved Hide resolved
@wei840222 wei840222 dismissed stale reviews from thinkerou and appleboy via 9cbbe83 Jul 31, 2021
@appleboy appleboy merged commit 9a575a4 into gin-gonic:master Jul 31, 2021
19 checks passed
daheige pushed a commit to daheige/gin that referenced this issue Apr 18, 2022
…equest.Context() (gin-gonic#2769)

* fallback Context.Deadline() Context.Done() Context.Err() to Context.Request.Context()

* update comments wording
@jerome-laforge
Copy link
Contributor

jerome-laforge commented May 31, 2022

It seems that this PR is breaking change in regard of how works gin v1.7 (#3166)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants