Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweaks,optimize code #2788

Merged
merged 1 commit into from Aug 22, 2021
Merged

minor tweaks,optimize code #2788

merged 1 commit into from Aug 22, 2021

Conversation

lancoLiu
Copy link
Contributor

@lancoLiu lancoLiu commented Jul 13, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #2788 (e000fa4) into master (caf2802) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2788      +/-   ##
==========================================
- Coverage   98.70%   98.70%   -0.01%     
==========================================
  Files          41       41              
  Lines        2085     2080       -5     
==========================================
- Hits         2058     2053       -5     
  Misses         15       15              
  Partials       12       12              
Impacted Files Coverage Δ
render/json.go 84.12% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf2802...e000fa4. Read the comment docs.

Copy link
Contributor

@zihengCat zihengCat left a comment

LGTM

Copy link
Contributor

@daheige daheige left a comment

@appleboy support it!

render/json.go Show resolved Hide resolved
@thinkerou thinkerou added this to the v1.8 milestone Aug 22, 2021
@thinkerou thinkerou requested review from thinkerou and appleboy Aug 22, 2021
Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@appleboy appleboy merged commit 4e75841 into gin-gonic:master Aug 22, 2021
17 of 19 checks passed
daheige pushed a commit to daheige/gin that referenced this issue Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants