Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizations for string to bytes conversion without memory allocation as defined in internals #2822

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

optimizations for string to bytes conversion without memory allocation as defined in internals #2822

wants to merge 1 commit into from

Conversation

zubairhassan652
Copy link

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@zubairhassan652
Copy link
Author

as this optimization send by @lancoLiu but its failing workflows, i just change the same code test using mac all test are passing on my side.

@zubairhassan652 zubairhassan652 mentioned this pull request Aug 13, 2021
Merged
daheige
daheige previously approved these changes Sep 6, 2021
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daheige daheige daheige left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zubairhassan652 @daheige