Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically SetMode to TestMode when run go test. #3139

Merged
merged 1 commit into from May 14, 2022

Conversation

micanzhang
Copy link
Contributor

@micanzhang micanzhang commented May 5, 2022

related issue: #3134

@micanzhang
Copy link
Contributor Author

micanzhang commented May 5, 2022

@appleboy PTAL

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #3139 (7f014d9) into master (90e7073) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3139   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          41       41           
  Lines        3109     3112    +3     
=======================================
+ Hits         3071     3074    +3     
  Misses         26       26           
  Partials       12       12           
Flag Coverage Δ
go-1.14 98.77% <100.00%> (+<0.01%) ⬆️
go-1.15 98.61% <100.00%> (+<0.01%) ⬆️
go-1.16 98.59% <100.00%> (+<0.01%) ⬆️
go-1.17 98.52% <100.00%> (+<0.01%) ⬆️
go-1.18 98.52% <100.00%> (+<0.01%) ⬆️
macos-latest 98.61% <100.00%> (-0.16%) ⬇️
nomsgpack 98.76% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 98.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mode.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e7073...7f014d9. Read the comment docs.

@micanzhang
Copy link
Contributor Author

micanzhang commented May 11, 2022

@appleboy PTAL

@appleboy appleboy added this to the v1.8 milestone May 13, 2022
@appleboy
Copy link
Member

appleboy commented May 13, 2022

Need @thinkerou approval.

@thinkerou thinkerou merged commit ef687e0 into gin-gonic:master May 14, 2022
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants