changed the method 'Header(key, value string)' on 'type Context' to '… #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SetHeader(key, value string)' for more clarity and to match the method 'GetHeader(key string)string'
ri8ika
reviewed
May 11, 2023
| @@ -858,7 +858,7 @@ func (c *Context) Status(code int) { | |||
| // Header is an intelligent shortcut for c.Writer.Header().Set(key, value). | |||
| // It writes a header in the response. | |||
| // If value == "", this method removes the header `c.Writer.Header().Del(key)` | |||
| func (c *Context) Header(key, value string) { | |||
| func (c *Context) SetHeader(key, value string) { | |||
There was a problem hiding this comment.
This will introduce big blunder to existing projects. The Header method is more appropriate than SetHeader in comparison with other methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…SetHeader(key, value string)' for more clarity and to match the method 'GetHeader(key string)string'
master