-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed: 1962 Link Diversity Insight. #2028
Closed
gbrady92
wants to merge
208
commits into
ThinkUpLLC:thinkup.com
from
gbrady92:1962-diversify-your-links
Closed
Completed: 1962 Link Diversity Insight. #2028
gbrady92
wants to merge
208
commits into
ThinkUpLLC:thinkup.com
from
gbrady92:1962-diversify-your-links
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: * Redesign OSP admin views for plugins other than Facebook and Twitter * Delete old dashboard and menu interfaces, classes, registrars, tests * Add missing test coverage * Clean up code
…note in the footer
- URL-encode network username and network on insight headline links - Show correct network icon for each insight - Don't replace the colon in insight headlines - Improve test coverage Closes ThinkUpLLC#1809
When a non-logged-in user accesses an AuthController, redirect to the login page with a redirect GET parameter. On login, redirect the user to that original URL.
Add Smarty plugin to custom URL encode network usernames with spaces and accented characters
* Also temporarily regenerate insights to fix copy.
Include "That's" before comparisons. Only show healthy share of tweets body for replies and retweets. Output debug copy for headline alternates.
…-spice-of-response-time Insight fix: Variety should be the spice of response time
…ombs Insight fix: Don't show negative F-bombs
Nudges a user to post a photo if they haven't in the past week, as long as they have in the past two weeks. References ThinkUpLLC#1619
Simple Javascript tool to preview various headlines and bodies emebdded in the html of an insight.
After a week since the last time the insight was generated, if there are new memberships, any missed in the past week are shown. Also adds additional headline options.
Insight text tester
…hip-repitition Insight fix: Reduce group membership repetition
Insight fix: Fix singular like in weekly graph insight
…me-me-or-mi-mi-mi-do-re Insight fix: Handle .me TLD more comprehensively in all about me Closes ThinkUpLLC#1991
…ight Photo Prompt Insight closes ThinkUpLLC#1619
…ll-noisy Stem Activity spike insight noise
Added config file, README docs for insight-html-to-server
…to-dislike-these-follower-count-tests Use mktime to calculate relative months for follower count tests.
…m different sources.
I'm closing this pull request due to my local thinkup install messing up which required me to create a new branch to create a new pull request. New pull request can be found here: #2043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The insight has a monthly and weekly version, each insight collects the links a user shared through their posts or tweets within the time frame and checks if any website accounts for over 50% over the links shared.
If the over 50% condition is met the insight generates and encourages the user to share links from different websites. The insight text is displayed with a pie chart of either the last 100 or 50 links depending on how many links are stored.