Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add config #166

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Re-add config #166

merged 1 commit into from
Oct 7, 2020

Conversation

jason-fox
Copy link
Contributor

@apozohue10 - You are right to exclude config.js in the .gitignore but you need a config.js in the build to run the app. This is now just a POJO style object with defaults like the template. Some users may choose to inject config.js as a docker volume rather than configure via ENV as well.

This also fixes the Unit-Test fail

@jason-fox
Copy link
Contributor Author

Once you have merged this, could you move the release tags (or delete and re-create them) so I can complete the FIWARE release? Thanks

@apozohue10
Copy link
Contributor

Hi Jason,

I have been looking for another solution. I am going to add this sentence to the travis file:

cp config.js.template config.js.

And also I added these two ones for the Dockerfile:

RUN cp config.js.template config.js
RUN rm config.js.template

I have tested and the Travis tests run correctly and the Docker Image is working too. Do you think it make sense?

@jason-fox
Copy link
Contributor Author

Leaving the config.js in the codebase(.gitignore protected) and not copying the config.js.template over makes more sense to me, in that if run locally and I make changes to my own config.js I see those changes, so it is confusing if I make my own docker images for my own changes to be overwritten with the template.

Leave config.js.template as a template I say and keep travis and the docker file simple.

Easiest way would be to:

docker checkout master
docker reset --hard 0ce701d
docker push -f

and then merge this.

@apozohue10 apozohue10 merged commit 42b0a61 into ging:master Oct 7, 2020
@jason-fox jason-fox deleted the feature/config branch May 7, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants