Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #221 - Add headless clustering mode #234

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

jason-fox
Copy link
Contributor

Proposed changes

  • Add clustering
  • Add IDM_HEADLESS ENV
  • Remove GUI routes from headless.

On the basis of an ENV variable, Keyrock should be run without sessions and without a GUI just servicing the PDP and IDM and API endpoints

Types of changes

What types of changes does your code introduce to the project: Put an x in
the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read the
    CONTRIBUTING
    doc
  • I have signed the
    CLA
  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream
    modules

- Add clustering
- Add IDM_HEADLESS ENV
- Remove GUI routes from headless.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2021

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@jason-fox
@apozohue10
You can retrigger this bot by commenting recheckcla in this Pull Request

@jason-fox
Copy link
Contributor Author

After discussion with @wistefan, we believe it makes sense to keep this functionality in a single repo under an ENV flag. The Dockerfile has been updated to also allow headless to be passed as a build ARG.

@apozohue10 apozohue10 merged commit 627d3ee into ging:master Nov 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants