Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the
validateScope
method to allow providing a space-separated list of scopes (in addition to support current comma-separated behaviour). This PR also adds unit tests.Types of changes
to not work as expected)
Checklist
CONTRIBUTING
doc
CLA
works
modules
Further comments
OAuth2/Open ID Connect services use space-separated lists of scopes by default, so this should make standard clients happier and allow to use more libraries for connecting to KeyRock. In any case, the default comma-separated behaviour should be maintained and ensured due to the new unit tests.
Now that KeyRock uses a custom implementation of
oauth-server
, the implementation can be simplified avoiding to tests if thescope
parameter is an argument array or just the scope string (I think that this requirement is meet just at current version but please, confirm if possible).