Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roles and permissions check for trusted application #342

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

fisuda
Copy link
Contributor

@fisuda fisuda commented Aug 21, 2023

Proposed changes

This PR fixes roles and permissions check for trusted application.

Types of changes

What types of changes does your code introduce to the project: Put an x in
the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read the
    CONTRIBUTING
    doc
  • I have signed the
    CLA
  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream
    modules

Further comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc...

@github-actions
Copy link
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@apozohue10 apozohue10 merged commit 2ca26b2 into ging:master Aug 31, 2023
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
@fisuda fisuda deleted the fix/trusted_application branch August 31, 2023 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants