Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #144 - Force Content Type to match proxied response. #145

Merged
merged 7 commits into from
Jun 9, 2023

Conversation

jason-fox
Copy link
Contributor

Proposed changes

Content-type is defaulting to text/html in Express unless explicitly set.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheckcla in this Pull Request

@jason-fox
Copy link
Contributor Author

recheckcla

@jason-fox
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jason-fox
Copy link
Contributor Author

recheckcla

@jason-fox
Copy link
Contributor Author

recheck

@jason-fox
Copy link
Contributor Author

@apozohue10 - any chance you could look at this before making an 8.3.1 release?

@apozohue10 apozohue10 merged commit 2a312fc into ging:master Jun 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
@jason-fox jason-fox deleted the feature/set-type branch March 25, 2024 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants