Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bitmap blit with ngfx blit #131

Merged
merged 4 commits into from Oct 23, 2018
Merged

Conversation

Helco
Copy link
Collaborator

@Helco Helco commented Oct 21, 2018

So this turned out to be quite a bit of work, I'll try to summarize the issues on the way:

  • png loader: did not set free_data_on_destroy, thus the aggressive loading of the menu filled up RAM very fast
  • png loader: the no-palette-but-alphas fix for 4Bit is also needed for 2Bit/1Bit palette bitmaps
  • png loader: 1Bit uses lsb->msb bitorder, for now I opted for creating a palette (like with ^) and turning it into 1BitPalette
  • app_manager: rwatch_neographics_init was being called quite often, dicussed temporary fix for this was moving the call into the overlay thread init (tracked in graphics context smashed pebble-dev/RebbleOS#62)
  • menu: should set the compop to Set before drawing icons as to enable blending

lib/png/png.c Outdated Show resolved Hide resolved
@jwise
Copy link
Collaborator

jwise commented Oct 23, 2018

Looks great to me. Does this depend on #130 and the resource change associated? If not, feel free to merge.

Co-Authored-By: Helco <hermann.noll@hotmail.com>
@Helco
Copy link
Collaborator Author

Helco commented Oct 23, 2018

Yes, Tintin won't show any bitmaps without #130

@jwise
Copy link
Collaborator

jwise commented Oct 23, 2018

Ok, add one more commit to this PR to update the submodule and then I'll merge the whole thing?

@Helco
Copy link
Collaborator Author

Helco commented Oct 23, 2018

sure there you go

@jwise jwise merged commit 064b4c2 into ginge:master Oct 23, 2018
@jwise
Copy link
Collaborator

jwise commented Oct 23, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants