IPC-261 Previously extracted information visible on InvoicesActivity
#437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sActivity` IPC-261
|
danicretu
commented
May 23, 2024
Comment on lines
+133
to
143
| launch { | ||
| viewModel.openBankState.collect { paymentState -> | ||
| when (paymentState) { | ||
| is GiniHealth.PaymentState.Success -> { | ||
| viewModel.updateDocument() | ||
| } | ||
| else -> {} | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The reason for keeping this in is the following use case:
- The users reaches
ReviewFragment - The user modifies the amount and / or the recipient
- The user taps on
To the banking app - From the bank screen the user hits
Backuntil reaching theInvoices screen(without completing the payment)
The InvoiceActivity is still active at this point, so we can just update the one document instead of adding a whole reload to the resumed state of the lifecycle. I am open to changes though 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPC-261