Feature default app dialog #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 4, 2019 19:03
kikettas
approved these changes
Feb 8, 2019
| showError(mDocumentAnalysisErrorMessage, | ||
| mFragment.getActivity().getString(R.string.gv_document_analysis_error_retry), | ||
| new View.OnClickListener() { | ||
| if (MimeType.APPLICATION_PDF.asString().equals(mMultiPageDocument.getMimeType())) { |
There was a problem hiding this comment.
This 🔺 cannot be avoided, can it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GVL is launched with an external file (aka "open with") we now check whether the app is set as default for that file type. If the app is the default, then we show an alert informing the user about this and telling them how to revert this. The user can either continue or be directed to the app's screen in the Android Settings app.
For images the dialog is shown in the review screens and for pdfs in the analysis screen.
Note: Showing an alert was only possible in the camera screen before. I had to touch a lot of files to allow the other screen to show dialogs, too, with minimal code duplication.
How to test
Open a pdf or an image with one of the example apps and use the
ALWAYSoption. The dialog should be shown.