anticipate Thomas' review comments

ginkgo-project · Jul 16, 2021 · 16c9397 · 16c9397
1 parent 2452e19
commit 16c9397
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/reference/factorization/ic_kernels.cpp b/reference/factorization/ic_kernels.cpp
@@ -33,6 +33,9 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include "core/factorization/ic_kernels.hpp"
 
 
+#include <ginkgo/core/base/math.hpp>
+
+
 #include "core/base/allocator.hpp"
 
 

diff --git a/reference/factorization/ilu_kernels.cpp b/reference/factorization/ilu_kernels.cpp
@@ -33,6 +33,12 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include "core/factorization/ilu_kernels.hpp"
 
 
+#include <algorithm>
+
+
+#include <ginkgo/core/base/math.hpp>
+
+
 #include "core/base/allocator.hpp"
 
 
@@ -67,10 +73,10 @@ void compute_lu(std::shared_ptr<const DefaultExecutor> exec,
             auto value = values[nz];
             const auto l_begin = begin;
             const auto l_end = end;
-            for (auto l_nz = begin; l_nz < end; l_nz++) {
+            for (auto l_nz = l_begin; l_nz < l_end; l_nz++) {
                 // for each lower triangular entry l_ik
                 const auto l_col = col_idxs[l_nz];
-                if (l_col >= std::min(row, col)) {
+                if (l_col >= min(row, col)) {
                     continue;
                 }
                 // find corresponding entry u_kj