Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELLPACK reference kernels #2

Closed
7 tasks
gflegar opened this issue Feb 7, 2018 · 0 comments · Fixed by #12
Closed
7 tasks

ELLPACK reference kernels #2

gflegar opened this issue Feb 7, 2018 · 0 comments · Fixed by #12
Assignees
@yhmtsai @yanjen
Labels
is:new-feature A request or implementation of a feature that does not exist yet.

Comments

@gflegar
Copy link
Member

gflegar commented Feb 7, 2018

  • requires ELLPACK matrix format #1
  • implement device dependent methods in core/matrix/ell.cpp
  • declare all kernels required by device dependent methods in core/base/ell_kernels.hpp
  • define these kernels as NOT_COMPILED in core/base/device_hooks/common_kernels.inc.cpp
  • define these kernels as NOT_IMPLEMENTED in cpu/matrix/ell_kernels.cpp and gpu/matrix/ell_kernels.cu
  • provide reference implementations of these kernels in reference/matrix/ell_kernels.cpp
  • add unit tests for device-dependent methods in reference/test/matrix/ell_kernels.cpp
@gflegar gflegar mentioned this issue Feb 7, 2018
Closed
3 tasks
@gflegar gflegar added the is:new-feature A request or implementation of a feature that does not exist yet. label Feb 7, 2018
@yhmtsai yhmtsai mentioned this issue Feb 14, 2018
Merged
@hartwiganzt hartwiganzt mentioned this issue May 11, 2018
Merged
greole added a commit that referenced this issue Sep 11, 2021
@greole
Data validation macro generalisation (#1)
36d2357 
* add prefixed macro definition

* Data validation macro generalisation fix windows (#2)

* check if linebreak causes windows build to break

* check if linebreak causes windows build to break

* check if empty macro arg causes windows build to break

* test if removing VA_ARGS resolves msvc error

* test PASS_ON hack

* Add missing PASS_ON

* Add tests for complex values is_finite tests

* Refactor macro expansion macro

* Test if PASS_ON is needed when calling GKO_APPLY_MACRO

* Refactor CALL_AND_RETURN_IF_CASTABLE macro

* Moves GKO_CALL_FOR_... macros to types.hpp
greole added a commit that referenced this issue Sep 27, 2021
@greole
Data validation macro generalisation (#1)
185d7fa 
* add prefixed macro definition

* Data validation macro generalisation fix windows (#2)

* check if linebreak causes windows build to break

* check if linebreak causes windows build to break

* check if empty macro arg causes windows build to break

* test if removing VA_ARGS resolves msvc error

* test PASS_ON hack

* Add missing PASS_ON

* Add tests for complex values is_finite tests

* Refactor macro expansion macro

* Test if PASS_ON is needed when calling GKO_APPLY_MACRO

* Refactor CALL_AND_RETURN_IF_CASTABLE macro

* Moves GKO_CALL_FOR_... macros to types.hpp
greole added a commit that referenced this issue Oct 15, 2021
@greole
Data validation macro generalisation (#1)
aadbcbb 
* add prefixed macro definition

* Data validation macro generalisation fix windows (#2)

* check if linebreak causes windows build to break

* check if linebreak causes windows build to break

* check if empty macro arg causes windows build to break

* test if removing VA_ARGS resolves msvc error

* test PASS_ON hack

* Add missing PASS_ON

* Add tests for complex values is_finite tests

* Refactor macro expansion macro

* Test if PASS_ON is needed when calling GKO_APPLY_MACRO

* Refactor CALL_AND_RETURN_IF_CASTABLE macro

* Moves GKO_CALL_FOR_... macros to types.hpp
@xwentian2020 xwentian2020 mentioned this issue Nov 3, 2022
Closed
@uboats uboats mentioned this issue Nov 24, 2023
Closed
@uboats uboats mentioned this issue Dec 18, 2023
Open
MarcelKoch added a commit that referenced this issue Apr 22, 2024
@MarcelKoch
# This is a combination of 2 commits.
dc0639b 
# This is the 1st commit message:

adds distributed index map

# The commit message #2 will be skipped:

# fixup! adds distributed index map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yhmtsai yhmtsai

@yanjen yanjen

Labels
is:new-feature A request or implementation of a feature that does not exist yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ell reference yhmtsai/ginkgo
3 participants
@gflegar @yhmtsai @yanjen