Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically detect CUDA and OpenMP support in CMake #213

Closed
thoasm opened this issue Jan 30, 2019 · 0 comments · Fixed by #435
Closed

Automatically detect CUDA and OpenMP support in CMake #213

thoasm opened this issue Jan 30, 2019 · 0 comments · Fixed by #435
Labels
is:new-feature A request or implementation of a feature that does not exist yet. mod:cuda This is related to the CUDA module. mod:openmp This is related to the OpenMP module. reg:build This is related to the build system.

Comments

@thoasm
Copy link
Member

thoasm commented Jan 30, 2019

Currently, we need to specify in CMake what we require, and if, for example, CUDA is required and not present, CMake fails and generates an error message.

In the future, it would be nice to automatically detect if CUDA or OpenMP is present (if CMake is called without parameters for that) and build everything that is possible.
This would increase the usability of ginkgo because the CMake step would get a lot simpler and less error prone due to a smaller chance of writing a parameter wrong.
@thoasm thoasm added is:enhancement An improvement of an existing feature. is:new-feature A request or implementation of a feature that does not exist yet. reg:build This is related to the build system. mod:cuda This is related to the CUDA module. mod:openmp This is related to the OpenMP module. mod:reference This is related to the reference module. and removed is:enhancement An improvement of an existing feature. labels Jan 30, 2019
@tcojean tcojean removed the mod:reference This is related to the reference module. label Feb 16, 2019
@upsj upsj mentioned this issue Dec 27, 2019
Merged
1 task
@upsj upsj closed this as completed in #435 Jan 10, 2020
upsj added a commit that referenced this issue Jan 10, 2020
@upsj
Auto-detect compilation settings based on present compilers/libraries
571d287 
This PR changes the default behavior for executing cmake without additional arguments: Instead of only compiling Reference, it compiles all executors for which the corresponding compiler/library was found.

Closes #213

Related PR: #435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:new-feature A request or implementation of a feature that does not exist yet. mod:cuda This is related to the CUDA module. mod:openmp This is related to the OpenMP module. reg:build This is related to the build system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto-detect compilation settings based on present compilers/libraries ginkgo-project/ginkgo
2 participants
@thoasm @tcojean