Remove HWLOC #1510
Open
Remove HWLOC #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
MarcelKoch
force-pushed
the
remove-hwloc
branch
from
04d3843
to
b549082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes HWLOC. Over time the hwloc component in Ginkgo seem to have lost its functionality, and now, it does absolutely nothing. We only use it to create the
machine_topologyclass, but at no point we are actually using any of the data it stores.So, this deprecates/removes the cmake option for HWLOC, and removes all references to it in our code. This again shows that we did not use HWLOC in any relevant capacity.
One point for discussion: I didn't remove
Executor::populate_exec_info(machine_topology*), although themachine_topologyclass is basically empty. But that function is protected, so it's part of our interface. Removing it would be a bit simpler, but we would need to decide on that.