Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows gitlab job #1617

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Add Windows gitlab job #1617

merged 5 commits into from
Jun 27, 2024

Conversation

upsj
Copy link
Member

@upsj upsj commented May 24, 2024

This adds CI jobs on a Windows gitlab-runner with an NVIDIA GPU

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label May 24, 2024
@upsj upsj requested a review from a team May 24, 2024 10:15
@upsj upsj self-assigned this May 24, 2024
@ginkgo-bot ginkgo-bot added the reg:ci-cd This is related to the continuous integration system. label May 24, 2024
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can also delete the CUDA Windows Action.
BTW, I hope it does not create an vm on that. Will windows license be an issue?

.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
@upsj
Copy link
Member Author

upsj commented May 24, 2024

This is a physical machine with an NVIDIA RTX 2060, an AMD RX 7600 and a valid Windows license. I am planning to try and get HIP running on Windows as well, see https://streamhpc.com/blog/2023-08-01/how-to-get-full-cmake-support-for-amd-hip-sdk-on-windows-including-patches/ for details.

Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be updated with the latest changes to our windows CI (the library size stuff)?

.gitlab-ci.yml Show resolved Hide resolved
@upsj upsj added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Jun 26, 2024
@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jun 26, 2024
@upsj
Copy link
Member Author

upsj commented Jun 27, 2024

All relevant pipelines ran through, so I'll go ahead and merge this

@upsj upsj merged commit 4beeab6 into develop Jun 27, 2024
12 of 14 checks passed
@upsj upsj deleted the windows-gitlab-runner branch June 27, 2024 14:46
Copy link

sonarcloud bot commented Jun 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. reg:ci-cd This is related to the continuous integration system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants