-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows gitlab job #1617
Add Windows gitlab job #1617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can also delete the CUDA Windows Action.
BTW, I hope it does not create an vm on that. Will windows license be an issue?
This is a physical machine with an NVIDIA RTX 2060, an AMD RX 7600 and a valid Windows license. I am planning to try and get HIP running on Windows as well, see https://streamhpc.com/blog/2023-08-01/how-to-get-full-cmake-support-for-amd-hip-sdk-on-windows-including-patches/ for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be updated with the latest changes to our windows CI (the library size stuff)?
8f3a7c1
to
b28882e
Compare
All relevant pipelines ran through, so I'll go ahead and merge this |
|
This adds CI jobs on a Windows gitlab-runner with an NVIDIA GPU