Release 1.3.0 for master #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the name and the commit number of CudaArchitectureSelector
We only need num_cols columns, not stride
* Copy libraries with correct version + symlinks * Add RPATH linker flag * Add missing pthread flag
* formatting * fix duplicate output * add example description Co-authored-by: Yuhsiang M. Tsai <yhmtsai@gmail.com> Co-authored-by: Fritz Goebel <goebel.fritz@googlemail.com>
1. use components prefix_sum in parilut 2. prefix_sum uses correct shared_memory value_type
Co-authored-by: Tobias Ribizel <ribizel@kit.edu> Co-authored-by: Thomas Grützmacher <thomas.gruetzmacher@kit.edu>
Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
On some systems, this can cause problems if the two compilers are tied to different glib versions. At linking time (esp. for examples or tests), it is then possible that some symbols are not found.
Co-authored-by: Thomas Grützmacher <thomas.gruetzmacher@kit.edu> Co-authored-by: Terry Cojean <terry.cojean@kit.edu>
Co-authored-by: tcojean <terry.cojean@kit.edu>
* move away from CMake 2.8 * add project(...) to external projects * set a few CMake policies
+ Replace our own code with calls to the standard implementation + Do not directly call `xstd` in our code for base C++14 features.
+ Apply the filter only to specific file patterns. Replacing all `$` characters by `\f$` creates a big issue in bash and other languages where `$` has another signification. This convenience feature is needed only for the hpp/cpp/cu* files. + Remove the `FILE_VERSION_FILTER` from the Doxyfile configuration: this command is used to extract the version of every file and is always ran. We already publish the version of Ginkgo so it's unneeded. In addition, when building out of source, the example files are not part of a git repository and that creates issues. + Remove the `doxygen_image_path` as it's unused and throws a warning + Use `Ginkgo_SOURCE_DIR` to locate the md files instead of `../..`.
+ s/CygWin/Cygwin/ + Add a reference to the JOSS paper in `CITING.md` Co-authored-by: Yuhsiang M. Tsai <yhmtsai@gmail.com> Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
tcojean
added
1:ST:ready-for-review
yhmtsai
approved these changes
Aug 26, 2020
pratikvn
approved these changes
Aug 26, 2020
upsj
approved these changes
Aug 26, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 84.22% 92.88% +8.66%
==========================================
Files 296 303 +7
Lines 20655 21331 +676
==========================================
+ Hits 17397 19814 +2417
+ Misses 3258 1517 -1741
Continue to review full report at Codecov.
|
upsj
added
1:ST:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the release to the master branch.
To get a proper view of what really changed, use in the ginkgo repository:
This should correctly report that only a few references change from develop to master.