Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump copyright year to 2021 #687

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Bump copyright year to 2021 #687

merged 2 commits into from
Jan 7, 2021

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Jan 4, 2021

This PR bumps the copyright year to 2021.
Edit the LICENSE and make format

@upsj do I also need to change the year of gdb-ginkgo.py? or does it need to wait the pretty-printers

Happy new year!

@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Jan 4, 2021
@yhmtsai yhmtsai requested a review from a team January 4, 2021 16:51
@yhmtsai yhmtsai self-assigned this Jan 4, 2021
@ginkgo-bot ginkgo-bot added mod:core This is related to the core module. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:benchmarking This is related to benchmarking. type:factorization This is related to the Factorizations type:matrix-format This is related to the Matrix formats type:preconditioner This is related to the preconditioners type:solver This is related to the solvers labels Jan 4, 2021
Copy link
Member

@tcojean tcojean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is not related to the PR here, but can be seen thanks to all these changes. Somehow, the bot wasn't able to detect that DPC++, OMP and Reference files changed. I think it's an issue with how the regex is written without simple quotes? Similarly, "reg:ci-cd" should be added for .github folder changes as well.

@tcojean
Copy link
Member

tcojean commented Jan 4, 2021

Too bad, using the reviewers github group doesn't work as we would expect: when one person approves, it's like the whole group approved. Whereas what we want is "get any two persons from the group to review this".

@upsj
Copy link
Member

upsj commented Jan 4, 2021

Relating to the gdb pretty printers: I don't think we necessarily need to update the license date there unless we modify the file itself. I think this is only important for files which get formatted automatically.

@tcojean
Copy link
Member

tcojean commented Jan 4, 2021

label!

@yhmtsai
Copy link
Member Author

yhmtsai commented Jan 4, 2021

Is the bot from develop not this branch?

@upsj
Copy link
Member

upsj commented Jan 4, 2021

The issue is that the bot only takes the first page of changed files for simplicity, since these huge diffs are rare, I think we can ignore this issue. Also @yhmtsai is correct, the script is run from develop.

@tcojean
Copy link
Member

tcojean commented Jan 4, 2021

Yes I realized later that would not update it here. And I see, I thought that the issue would be that bash somehow interprets and gobbles the ^ in its own way, like it can happen to ! and other characters sometimes.

Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhmtsai
Copy link
Member Author

yhmtsai commented Jan 4, 2021

The maximum of one page is 100 even if we specify it &per_page=1000 in label.sh

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #687 (073d3ba) into develop (682d120) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #687      +/-   ##
===========================================
- Coverage    92.88%   92.86%   -0.03%     
===========================================
  Files          333      333              
  Lines        24429    24266     -163     
===========================================
- Hits         22692    22535     -157     
+ Misses        1737     1731       -6     
Impacted Files Coverage Δ
core/base/allocator.hpp 100.00% <ø> (ø)
core/base/array.cpp 100.00% <ø> (ø)
core/base/combination.cpp 45.94% <ø> (ø)
core/base/composition.cpp 73.84% <ø> (ø)
core/base/executor.cpp 15.38% <ø> (ø)
core/base/extended_float.hpp 91.26% <ø> (-0.98%) ⬇️
core/base/iterator_factory.hpp 97.59% <ø> (ø)
core/base/mtx_io.cpp 84.32% <ø> (ø)
core/base/perturbation.cpp 100.00% <ø> (ø)
core/base/utils.hpp 100.00% <ø> (ø)
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81df3be...73a2bc1. Read the comment docs.

@tcojean tcojean added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jan 6, 2021
@yhmtsai yhmtsai removed mod:core This is related to the core module. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:benchmarking This is related to benchmarking. labels Jan 7, 2021
@yhmtsai yhmtsai removed type:factorization This is related to the Factorizations type:matrix-format This is related to the Matrix formats type:preconditioner This is related to the preconditioners type:solver This is related to the solvers labels Jan 7, 2021
@yhmtsai
Copy link
Member Author

yhmtsai commented Jan 7, 2021

label!

@ginkgo-bot ginkgo-bot added mod:all This touches all Ginkgo modules. reg:benchmarking This is related to benchmarking. reg:documentation This is related to documentation. reg:example This is related to the examples. reg:testing This is related to testing. type:factorization This is related to the Factorizations type:matrix-format This is related to the Matrix formats type:preconditioner This is related to the preconditioners type:reordering This is related to the matrix(LinOp) reordering type:solver This is related to the solvers type:stopping-criteria This is related to the stopping criteria labels Jan 7, 2021
@ginkgo-bot
Copy link
Member

Error: The following files need to be formatted:

cuda/solver/idr_kernels.cu
hip/solver/idr_kernels.hip.cpp
omp/solver/idr_kernels.cpp
reference/solver/idr_kernels.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

@yhmtsai
Copy link
Member Author

yhmtsai commented Jan 7, 2021

format!

Co-authored-by: Yuhsiang M. Tsai <yhmtsai@gmail.com>
@yhmtsai
Copy link
Member Author

yhmtsai commented Jan 7, 2021

Maybe I do the format too quickly such that github action only takes the original commit not the github-bot-format commit.
Windows: https://github.com/ginkgo-project/ginkgo/actions/runs/468671383
Mac: https://github.com/ginkgo-project/ginkgo/actions/runs/468671387
The format commit only changes the order of header, so I will merge it directly not push it again.

@upsj
Copy link
Member

upsj commented Jan 7, 2021

Sounds sensible, also in #691 I will replace the headers by the correct C++-style headers, so this will not be an issue in the future.

@yhmtsai yhmtsai merged commit e533349 into develop Jan 7, 2021
@yhmtsai yhmtsai deleted the update_copyright_to_2021 branch January 7, 2021 19:25
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. mod:all This touches all Ginkgo modules. reg:benchmarking This is related to benchmarking. reg:documentation This is related to documentation. reg:example This is related to the examples. reg:testing This is related to testing. type:factorization This is related to the Factorizations type:matrix-format This is related to the Matrix formats type:preconditioner This is related to the preconditioners type:reordering This is related to the matrix(LinOp) reordering type:solver This is related to the solvers type:stopping-criteria This is related to the stopping criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants