-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump copyright year to 2021 #687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is not related to the PR here, but can be seen thanks to all these changes. Somehow, the bot wasn't able to detect that DPC++, OMP and Reference files changed. I think it's an issue with how the regex is written without simple quotes? Similarly, "reg:ci-cd" should be added for .github
folder changes as well.
Too bad, using the |
Relating to the gdb pretty printers: I don't think we necessarily need to update the license date there unless we modify the file itself. I think this is only important for files which get formatted automatically. |
label! |
Is the bot from develop not this branch? |
The issue is that the bot only takes the first page of changed files for simplicity, since these huge diffs are rare, I think we can ignore this issue. Also @yhmtsai is correct, the script is run from develop. |
Yes I realized later that would not update it here. And I see, I thought that the issue would be that bash somehow interprets and gobbles the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The maximum of one page is 100 even if we specify it |
Codecov Report
@@ Coverage Diff @@
## develop #687 +/- ##
===========================================
- Coverage 92.88% 92.86% -0.03%
===========================================
Files 333 333
Lines 24429 24266 -163
===========================================
- Hits 22692 22535 -157
+ Misses 1737 1731 -6
Continue to review full report at Codecov.
|
073d3ba
to
1f3cfa0
Compare
label! |
Error: The following files need to be formatted:
You can find a formatting patch under Artifacts here or run |
format! |
Co-authored-by: Yuhsiang M. Tsai <yhmtsai@gmail.com>
Maybe I do the |
Sounds sensible, also in #691 I will replace the headers by the correct C++-style headers, so this will not be an issue in the future. |
Kudos, SonarCloud Quality Gate passed!
|
This PR bumps the copyright year to 2021.
Edit the
LICENSE
andmake format
@upsj do I also need to change the year of gdb-ginkgo.py? or does it need to wait the pretty-printers
Happy new year!