Release 1.4.0 to master #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Terry Cojean <terry.cojean@kit.edu>
* remove MSVC support completely * only find packages if they are needed
This avoids printing a lengthy and maybe surprising error message:
CMake Warning at examples/CMakeLists.txt:39 (find_package):
By not providing "FindOpenCV.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "OpenCV", but
CMake did not find one.
Could not find a package configuration file provided by "OpenCV" with any
of the following names:
OpenCVConfig.cmake
opencv-config.cmake
Add the installation prefix of "OpenCV" to CMAKE_PREFIX_PATH or set
"OpenCV_DIR" to a directory containing one of the above files. If "OpenCV"
provides a separate development package or SDK, be sure it has been
installed.
HIP doesn't support CUDA 11.*
This reworks the previous adaptiv benchmarking. Now, the number of iteration is determined on-the-fly instead of before-hand. Also new cmd-line flags have been added to allow for greater control over the adaptive benchmarks. The usage is similar to google benchmark. Currently, it is not possible to use this approach for the preconditioner benchmark, as these do not update the runtime in each iteration.
this changes the preconditioner benchmark to time each preconditioner apply/generate individually, unifying the timing approach across all benchmarks.
- adds more documentation - minor formatting - made `status` private s.t. it is not part of the public interface of `IterationControl` Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com> Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
Now the `run_control` object also controls taking the timings. The user does not need to issue the timings by hand anymore. This allows to use increasingly larger intervals between two timings, unitl the benchmark run is finished. Drawback: everything within the `ic.run()` loop gets timed, parts that should be exempt need to be moved outside of the loop.
Internally this uses a thin wrapper class for the `timer` object, which just skips the `tic/toc` calls, if the `run_control` object does not manage the timings. In that case, the timings have to be issued outside as before.
- clarify documentation - add accessor to underlying timer - formatting - adds flag to choose repetitions growth factor Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com> Co-authored-by: Tobias Ribizel <ribizel@kit.edu> Co-authored-by: Terry Cojean <terry.cojean@kit.edu>
Since we added the DPCPP version information, we need to skip one additional line
Co-authored-by: Tobias Ribizel <ribizel@kit.edu> Co-authored-by: Yu-Hsiang Tsai <yhmtsai@gmail.com>
Co-authored-by: Terry Cojean <tcojean@users.noreply.github.com>
Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
additionally, switch order of RAP product
Co-authored-by: Yu-Hsiang Tsai <yhmtsai@gmail.com> Co-authored-by: Aditya Kashi <aditya.kashi@kit.edu> Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
yhmtsai
approved these changes
Aug 20, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
==========================================
+ Coverage 92.89% 94.41% +1.52%
==========================================
Files 303 416 +113
Lines 21331 33216 +11885
==========================================
+ Hits 19815 31361 +11546
- Misses 1516 1855 +339
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should port all the changes from 1.4.0 to master.
This needs some checking to ensure the correct range of commits is applied and that the references to master stay in place.