Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when it is not in git and add some possible clang-format #8

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Jul 15, 2021

This pr fixes the issue when the folder is not in valid git structure and add some possible clang-format
The folder copied or uploaded to other place leads the cmake error, which is from get_filename_component

@yhmtsai yhmtsai self-assigned this Jul 15, 2021
@yhmtsai yhmtsai requested a review from a team July 15, 2021 20:45
FindClangFormat.cmake Outdated Show resolved Hide resolved
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
@yhmtsai yhmtsai merged commit e9a82f2 into master Jul 16, 2021
@yhmtsai yhmtsai deleted the fix_no_git branch July 16, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants