Add queryset evaluation to actually lock root genome #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.djangoproject.com/en/2.2/ref/models/querysets/#select-for-u pdate doc tells that only `When the queryset is evaluated (for entry in entries in this case),` the lock will happen. I tested this on edge-staging and works as expected. The previous version without queryset evaluation did not work.
|
@yaoyuyang Looks great. Thanks. Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.djangoproject.com/en/2.2/ref/models/querysets/#select-for-u
pdate doc tells that only
When the queryset is evaluated (for entry in entries in this case),the lock will happen. I tested this onedge-staging and works as expected. The previous version without
queryset evaluation did not work.