on large import of a genome w/o any annotation, divide up only chunk … #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into workable chunk sizes too
yaoyuyang
requested changes
Aug 12, 2020
| @@ -1,6 +1,6 @@ | |||
| from django.db.backends.signals import connection_created | |||
|
|
|||
| __version__ = '2.6.0' | |||
| __version__ = '2.8.0' | |||
There was a problem hiding this comment.
What's the reason for bumping the version here in the PR? I think the flow is to run https://github.com/ginkgobioworks/edge#versioning on the master branch which will automatically bump the version and push a tag. Were you trying to release this branch on pypi?
There was a problem hiding this comment.
I think I just didn't know what I was doing.
|
So @benjiec, if I understand correctly, when we import genome without annotation before, we don't break up it into any chunks before or is it the case that we don't break up into small enough chunks? |
|
@yaoyuyang Looks like we don't break it up before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…into workable chunk sizes too