add a select_for_update lock #76
Conversation
| @@ -510,6 +510,11 @@ def find_root_genome(genome): | |||
|
|
|||
|
|
|||
| def lock_genome(genome): | |||
| """ | |||
| Do a select for update, which, when executed inside a transaction, places a | |||
There was a problem hiding this comment.
FYI I only spent two minutes poking into this, but from what I could tell, the places where you call lock_genome aren't inside transactions. Unless they're happening higher up in the call chain...
There was a problem hiding this comment.
Correct. It's upstream caller that's calling the atomic, because you need the locking and the rest of the work to happen all within a transaction. Should I change the method name to lock_genome_call_if_in_transaction? or you think the comment is sufficient.
src/edge/models/fragment.py
Outdated
| """ | ||
|
|
||
| fragments = Fragment.objects.select_for_update().filter(pk=self.id) | ||
| # Lock only happens when querset is evaluated, therefore need to do at least fragments[0] |
There was a problem hiding this comment.
Unless querset is a "short" name I'm not familiar with, I assume you meant queryset here. Not that it matters given that it's a comment...
There was a problem hiding this comment.
Yes, typo, will fix. Thanks.
No description provided.