Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sequence to feature and option to get in api #96

Merged
merged 5 commits into from
Sep 13, 2022
Merged

add sequence to feature and option to get in api #96

merged 5 commits into from
Sep 13, 2022

Conversation

Lioscro
Copy link
Contributor

@Lioscro Lioscro commented Sep 7, 2022

No description provided.

@Lioscro Lioscro requested a review from Chris7 September 8, 2022 02:21
@Lioscro Lioscro requested a review from Chris7 September 8, 2022 20:15
@Lioscro Lioscro self-assigned this Sep 8, 2022
@Lioscro
Copy link
Contributor Author

Lioscro commented Sep 9, 2022 •
edited
Loading

I know this is a bit ugly, but couldn't figure out a way to get collectstatic running correctly. Will remove static files after testing.

@Lioscro
Copy link
Contributor Author

Lioscro commented Sep 11, 2022 •
edited
Loading

Everything seems to be working as expected. Reverted the static files. Ready for review. @Chris7

Chris7
Chris7 reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@Chris7 Chris7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, can we get a simple test of something we know should be correct, like a start codon on the reverse strand is correctly returned as ATG instead of CAT?

@Lioscro Lioscro requested a review from Chris7 September 12, 2022 21:21
@Chris7
Copy link
Contributor

Chris7 commented Sep 13, 2022

Send it

@Lioscro Lioscro merged commit ab1df96 into master Sep 13, 2022
@Lioscro Lioscro deleted the include-feature-sequence branch September 13, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris7 Chris7 Awaiting requested review from Chris7

Assignees

@Lioscro Lioscro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lioscro @Chris7