Feature: implement insert orientation #18
Conversation
|
@ginpei Does this section make enough sense to you that you could help me implement this? I'm struggling to grasp what exactly what change needs made. https://github.com/hMatoba/piexifjs/blob/2180d60b8cdf638e236e0a6703b7c378bb4f5785/piexif.js#L69-L71 I think I have at least the beginning of what we need for tests. I think we may want to eventually move to |
|
@TonyBrobston I'll check it this weekend. As a quick look, what we need for the insert functionality are: 1. create the orientation segment 2. insert the segment into image. In the code you shared, the The term segment is an unit for image meta data. The structure of the JPEG file can be separated like HTML's |
|
|
|
The code would be like this. To insert things, we need a new buffer since buffer cannot be extended. function setOrientationCode () {
// JEPG does not have exif segment
if (!hasExifSegment()) {
createSegment();
appendSegment();
return output;
}
// The exif segment does not have orientation entry
if (!hasOrientationEntryInExifSegment()) {
createEntry();
appendEntry();
replaceSegment();
return output;
}
// OK orientation information exists
cloneInput(); // to make output same as the other patterns
overwriteOrientationCode();
return output;
}The code we have to add looks not tiny. Is it better to find replacement? |
|
When I have some time I'll try to implement something based on the information you provided. I'm still not confident I'll be successful, but I will try. |
|
@ginpei I was thinking we could grab all the code from here: https://github.com/hMatoba/piexifjs/blob/2180d60b8cdf638e236e0a6703b7c378bb4f5785/piexif.js#L56 |
|
@TonyBrobston Hi I'm so sorry for this long silence. And it's hard to additionally say, but I would not like to add this feature because I'm afraid that adding it requires almost full logic to access Exif data, and results in lots of new code, which increases file size and code complexity, while alternatives exist already. (Although I haven't tried the others actually.) If you could implement them once, and the change was small enough, I would change my mind. |
|
@ginpei It's alright. I'm not sure I'm capable of implementing this feature. Maybe someday in the future I will do. For now I'll close this. |
Unfortunately
updateOrientationCodedoesn't seem to really solve my problem. After compressing anFilethere is noorientationis-1. So I need the ability to insert/update orientation.It seems this may be the logic to do it: https://github.com/hMatoba/piexifjs/blob/2180d60b8cdf638e236e0a6703b7c378bb4f5785/piexif.js#L56